Run tests on PHP 8.4 and update test environment + fix nullable type deprecations #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal was to add PHP 8.4 support and upgrade to ubuntu-24.04. To achieve this, I had to fix PHP 8.4's implicitly nullable parameter deprecation warnings.
Since the project needs to support PHP 5.3+ and nullable types are only available from PHP 7.1+, I removed the type hints and implemented manual if-statements for type checking that work with all PHP versions and added tests to validate this behavior.
Additionally, updates to react/promise and clue/multicast-react dependencies were required, as well as adjustments to the search method using
array()instead of[]syntax and modified message collection to maintain PHP 5.3 compatibility.Builds on top of #16 and reactphp/promise#260.